[webkit-reviews] review granted: [Bug 70519] [Chromium] Fixed Layout API needs to check that a FrameView has been created to avoid segfaults : [Attachment 111874] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 20 17:07:44 PDT 2011


Adam Barth <abarth at webkit.org> has granted Fady Samuel <fsamuel at chromium.org>'s
request for review:
Bug 70519: [Chromium] Fixed Layout API needs to check that a FrameView has been
created to avoid segfaults
https://bugs.webkit.org/show_bug.cgi?id=70519

Attachment 111874: Patch
https://bugs.webkit.org/attachment.cgi?id=111874&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111874&action=review


> Source/WebKit/chromium/ChangeLog:9
> +	   Simple patch. Upcoming patches for
https://bugs.webkit.org/show_bug.cgi?id=70559 will make
> +	   use of these methods in certain situations where the main frame
doesn't yet have a FrameView.

Ok.  Please add tests for these branches as part of those bugs.


More information about the webkit-reviews mailing list