[webkit-reviews] review granted: [Bug 70483] Event.h shouldn't need to know about every ifdef and feature that uses events : [Attachment 111859] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 70483: Event.h shouldn't need to know about every ifdef and feature that
uses events
https://bugs.webkit.org/show_bug.cgi?id=70483

Attachment 111859: Patch
https://bugs.webkit.org/attachment.cgi?id=111859&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111859&action=review


Looks good to me.  I think you should consider changing interfaceName() to
something more descriptive.  Be it jsInterfaceName() or domInterfaceName().

I also think that it would make more sense to use
eventNames().xmlHttpRequestEventDomInterfaceName instead of eventNames().
interfaceForXMLHttpRequestProgressEvent, despite the capitalization issues.  We
had to handle capitalization (manually) in the ElementFactory code too.

> Source/WebCore/dom/Event.h:117
> +	   // These are needed for the CPP bindings.

Do you want a FIXME: here that we can remove most of these?