[webkit-reviews] review granted: [Bug 70455] [chromium/mac] Add support for building with make : [Attachment 111843] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Nico Weber <thakis at chromium.org>'s
request for review:
Bug 70455: [chromium/mac] Add support for building with make
https://bugs.webkit.org/show_bug.cgi?id=70455

Attachment 111843: Patch
https://bugs.webkit.org/attachment.cgi?id=111843&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111843&action=review


This is great.

> Tools/Scripts/webkitdirs.pm:922
> +    if (-e 'Makefile.chromium') {
> +	 unless (-e 'Source/WebKit/chromium/WebKit.xcodeproj') {
> +	   $hasUpToDateMakefile = 1;
> +	 } else {
> +	   $hasUpToDateMakefile = stat('Makefile.chromium')->mtime >
stat('Source/WebKit/chromium/WebKit.xcodeproj')->mtime;
> +	 }
> +    }

four-space indent.