[webkit-reviews] review granted: [Bug 70517] Implement SSE denormal disabler for windows. : [Attachment 111838] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Raymond Toy <rtoy at chromium.org>'s
request for review:
Bug 70517: Implement SSE denormal disabler for windows.
https://bugs.webkit.org/show_bug.cgi?id=70517

Attachment 111838: Patch
https://bugs.webkit.org/attachment.cgi?id=111838&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=111838&action=review


Looks good to me. One question, but r=me.

> Source/WebCore/platform/audio/DenormalDisabler.h:55
> +	   _controlfp_s(&unused, _DN_FLUSH, _MCW_DN);

Since the guard in flushDenormalFloatToZero includes (!_M_IX86_FP), would it
make sense to elide this block and the _controlfp_s call in the destructor if
(!_M_IX86_FP)?