[webkit-reviews] review denied: [Bug 70484] [WK2] Enable pixel test on WK2 if expected.png exists : [Attachment 111789] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Fehér Zsolt
<feherzs at inf.u-szeged.hu>'s request for review:
Bug 70484: [WK2] Enable pixel test on WK2 if expected.png exists
https://bugs.webkit.org/show_bug.cgi?id=70484

Attachment 111789: Patch
https://bugs.webkit.org/attachment.cgi?id=111789&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111789&action=review


> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:289
> +	   optparse.make_option("--wk2-pixel-test", action="store_true",
> +	       dest="wk2_pixel_test", help="Enable pixel-to-pixel PNG
comparisons on WebKit2"),

Why not just reuse --pixel? You already know if you're webkit2 from the
driver_name. Seems like you could simplify this patch a lot if you did so.

If there's a reason you need a new flag, you should explain it in the
changelog.