[webkit-reviews] review denied: [Bug 61558] iframe with scrolling=no incorrectly autoscrollable : [Attachment 111565] Patch to fix scrolling of frame content with "scrolling=no" - III

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has denied Swapna
<spottabathini at innominds.com>'s request for review:
Bug 61558: iframe with scrolling=no incorrectly autoscrollable
https://bugs.webkit.org/show_bug.cgi?id=61558

Attachment 111565: Patch to fix scrolling of frame content with "scrolling=no" 
- III
https://bugs.webkit.org/attachment.cgi?id=111565&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111565&action=review


> Source/WebCore/rendering/RenderLayer.cpp:1502
> +		   HTMLFrameElement* frameElt = 0;
> +		   Element* ownerElement = frameView->frame() ?
frameView->frame()->ownerElement() : 0;
> +
> +		   if (ownerElement && (ownerElement->hasTagName(frameTag) ||
ownerElement->hasTagName(iframeTag))) 
> +		       frameElt = static_cast<HTMLFrameElement*>(ownerElement);

> +
> +		   if (frameElt->scrollingMode() != ScrollbarAlwaysOff) {

it seems like "frameElt" can be 0 here if the "if" above fails.

frameElt is also not a recommended variable name.

also you are checking ownerElement three times.

> Source/WebCore/rendering/RenderLayer.cpp:1504
> +		       LayoutRect r = getRectToExpose(viewRect, rect, alignX,
alignY);

'r' is not a recommended variable name, althoug I know you are just moving
existing code to within an "if" block.