[webkit-reviews] review denied: [Bug 70478] [EFL] Unregister 'viewport, changed' signal in EWebLauncher : [Attachment 111730] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 20 05:47:41 PDT 2011


Raphael Kubo da Costa <kubo at profusion.mobi> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 70478: [EFL] Unregister 'viewport,changed' signal in EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=70478

Attachment 111730: Patch
https://bugs.webkit.org/attachment.cgi?id=111730&action=review

------- Additional Comments from Raphael Kubo da Costa <kubo at profusion.mobi>
Can you explain in more details what the problem with the current code is? I
couldn't understand it from the ChangeLog message.

Plus, if you're really going to unregister the signal, you can also remove the
whole on_viewport_changed function as well.


More information about the webkit-reviews mailing list