[webkit-reviews] review denied: [Bug 70474] [Forms][File] Add tooltip to "No file selected" text : [Attachment 111739] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 70474: [Forms][File] Add tooltip to "No file selected" text
https://bugs.webkit.org/show_bug.cgi?id=70474

Attachment 111739: Patch
https://bugs.webkit.org/attachment.cgi?id=111739&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111739&action=review


> Source/WebCore/ChangeLog:25
> +	   * html/FileInputType.cpp:
> +	   (WebCore::FileInputType::getToolTip):
> +	   * html/FileInputType.h:
> +	   * html/HTMLInputElement.cpp:
> +	   (WebCore::HTMLInputElement::getToolTip):
> +	   * html/HTMLInputElement.h:
> +	   * html/InputType.cpp:
> +	   (WebCore::InputType::getToolTip):
> +	   * html/InputType.h:
> +	   * page/Chrome.cpp:
> +	   (WebCore::Chrome::setToolTip):

Please write what is changed for each of files/functions as possible.

> Source/WebCore/html/HTMLInputElement.h:236
> +    String getToolTip() const;
> +

Please see item 6 and 7 of 'Names' section of
http://www.webkit.org/coding/coding-style.html.
This function should be toolTip()", not getToolTip().

Also, I think defaultToolTip() or fallbackToolTip() is better.

> Source/WebCore/html/InputType.h:241
> +    virtual String getToolTip() const;

ditto.