[webkit-reviews] review denied: [Bug 69137] In input field caret is not blinking after context menu hide : [Attachment 111734] WebCore changes

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied chandra shekar vallala
<chandra.vallala at motorola.com>'s request for review:
Bug 69137: In input field caret is not blinking after context menu hide
https://bugs.webkit.org/show_bug.cgi?id=69137

Attachment 111734: WebCore changes
https://bugs.webkit.org/attachment.cgi?id=111734&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111734&action=review


> Source/WebCore/page/EventHandler.cpp:2262
> +void respondToContextMenuShown()

We probably need to suspend caret blinking before showing context menu, so I'd
rename this function to willShowContextMenu.

Also, you're missing EventHandler::.

> Source/WebCore/page/EventHandler.cpp:2267
> +void respondToContextMenuDismissed()

Nit: s/respondToContextMenuDismissed/respondToContextMenuDismissal/.

Ditto about missing EventHandler:: r- because of this.