[webkit-reviews] review denied: [Bug 70474] [Forms][File] Add tooltip to "No file selected" text : [Attachment 111735] Patch 2

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 70474: [Forms][File] Add tooltip to "No file selected" text
https://bugs.webkit.org/show_bug.cgi?id=70474

Attachment 111735: Patch 2
https://bugs.webkit.org/attachment.cgi?id=111735&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111735&action=review


> Source/WebCore/ChangeLog:5
> +	   Changes for check-webkit-style

Do not include style changes.  They are unrelated to the bug.

Also, please write the reason why you change the behavior.

> Source/WebCore/ChangeLog:22
> +	   * html/FileInputType.cpp:
> +	   (WebCore::FileInputType::getToolTip):
> +	   * html/FileInputType.h:
> +	   * html/HTMLInputElement.cpp:
> +	   (WebCore::HTMLInputElement::parseMappedAttribute):
> +	   (WebCore::HTMLInputElement::getToolTip):
> +	   * html/HTMLInputElement.h:
> +	   * html/InputType.cpp:
> +	   (WebCore::InputType::getToolTip):
> +	   * html/InputType.h:
> +	   * page/Chrome.cpp:
> +	   (WebCore::Chrome::setToolTip):

Please write what you changed for each of files/functions as possible.

> Source/WebCore/html/FileInputType.h:68
> +    virtual String getToolTip() const;

Please append OVERRIDE.

> Source/WebCore/html/HTMLInputElement.cpp:54
> -#include "SearchInputType.h"
>  #include "ScriptEventListener.h"
> +#include "SearchInputType.h"

Do not change this in this patch.

> Source/WebCore/html/HTMLInputElement.cpp:800
> -	   // FIXME: Detaching just for maxResults change is not ideal.  We
should figure out the right
> +	   // FIXME: Detaching just for maxResults change is not ideal. We
should figure out the right

ditto.

> Source/WebCore/html/HTMLInputElement.h:59
> -    // Returns the minimum value for type=date, number, or range.  Don't
call this for other types.
> +    // Returns the minimum value for type=date, number, or range. Don't call
this for other types.
>      double minimum() const;
> -    // Returns the maximum value for type=date, number, or range.  Don't
call this for other types.
> +    // Returns the maximum value for type=date, number, or range. Don't call
this for other types.

ditto.

> Source/WebCore/html/HTMLInputElement.h:320
> -    
> +

ditto.

> Source/WebCore/html/HTMLInputElement.h:325
> -    // Helper for stepUp()/stepDown().  Adds step value * count to the
current value.
> +    // Helper for stepUp()/stepDown(). Adds step value * count to the
current value.

ditto.

> Source/WebCore/html/HTMLInputElement.h:357
> -} //namespace
> +} // namespace

ditto.

> Source/WebCore/html/InputType.h:36
> -#include <wtf/Forward.h>
>  #include <wtf/FastAllocBase.h>
> +#include <wtf/Forward.h>

ditto.

> Source/WebCore/html/InputType.h:77
> -    WTF_MAKE_NONCOPYABLE(InputType); WTF_MAKE_FAST_ALLOCATED;
> +    WTF_MAKE_NONCOPYABLE(InputType);
> +    WTF_MAKE_FAST_ALLOCATED;

ditto.

> Source/WebCore/page/Chrome.cpp:28
> -#include "FileIconLoader.h"
>  #include "FileChooser.h"
> +#include "FileIconLoader.h"

ditto.

> Source/WebCore/page/Chrome.cpp:424
> +		   // TODO(yosin): We should obtain text direction of tooltip

TODO(name) is chromium-style. We should change it to FIXME: .