[webkit-reviews] review denied: [Bug 70468] DFG call optimization handling will fail if the call had been unlinked due to the callee being optimized : [Attachment 111720] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 19 20:51:11 PDT 2011


Oliver Hunt <oliver at apple.com> has denied Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 70468: DFG call optimization handling will fail if the call had been
unlinked due to the callee being optimized
https://bugs.webkit.org/show_bug.cgi?id=70468

Attachment 111720: the patch
https://bugs.webkit.org/attachment.cgi?id=111720&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
lastSeenCallee isn't marked so this isn't safe, but also this may result in
dead functions being kept alive longer than is strictly necessary.  I would
almost consider going with a Weak<> ref rather than WriteBarrier<JSFunction> if
we can get do it without a perf impact


More information about the webkit-reviews mailing list