[webkit-reviews] review granted: [Bug 70431] Fix teardown in Web*LayerImpl : [Attachment 111713] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Antoine Labour
<piman at chromium.org>'s request for review:
Bug 70431: Fix teardown in Web*LayerImpl
https://bugs.webkit.org/show_bug.cgi?id=70431

Attachment 111713: Patch
https://bugs.webkit.org/attachment.cgi?id=111713&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111713&action=review


Yay tests that find bugs! R=me, few things to address while landing.

> Source/WebKit/chromium/tests/WebLayerTest.cpp:16
> + *	  * Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + *	  * Redistributions in binary form must reproduce the above
> + * copyright notice, this list of conditions and the following disclaimer
> + * in the documentation and/or other materials provided with the
> + * distribution.
> + *	  * Neither the name of Google Inc. nor the names of its
> + * contributors may be used to endorse or promote products derived from
> + * this software without specific prior written permission.

we prefer 2-clause nowadays, see Source/WebCore/LICENSE-APPLE (but put Google
Inc on the top line and only include the current year)

> Source/WebKit/chromium/tests/WebLayerTest.cpp:128
> +    EXPECT_EQ(3, textureLayer.textureId());

use "3u" here or the compiler will whine about signed/unsigned mismatch