[webkit-reviews] review granted: [Bug 70469] Document.cpp shouldn't need to know about every event for every feature : [Attachment 111714] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 70469: Document.cpp shouldn't need to know about every event for every
feature
https://bugs.webkit.org/show_bug.cgi?id=70469

Attachment 111714: Patch
https://bugs.webkit.org/attachment.cgi?id=111714&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111714&action=review


LGTM.

> Source/WebCore/WebCore.gyp/scripts/action_makenames.py:120
> +	   if inputBasename == 'make_names.pl' \
> +	       or inputBasename == 'make_event_factory.pl':

Really?

> Source/WebCore/dom/EventFactory.h:38
> +    static PassRefPtr<Event> create(const String& eventType);

AtomicString?