[webkit-reviews] review granted: [Bug 70448] compositing/video tests time out on Lion : [Attachment 111705] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 70448: compositing/video tests time out on Lion
https://bugs.webkit.org/show_bug.cgi?id=70448

Attachment 111705: Patch
https://bugs.webkit.org/attachment.cgi?id=111705&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=111705&action=review


> Source/WebCore/ChangeLog:13
> +	   AVFoundation will occasionally fill it's playback buffers before
collecting enough
> +	   statistical information to answer YES to isLikelyToKeepUp.  In this
situation, set the
> +	   ready state to HAVE_ENOUGH_DATA, on the presumption that if the
playback buffers are
> +	   full, playback will probably not stall.

It would be good to have this comment...

>
Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cp
p:453
>	       case MediaPlayerAVPlayerItemStatusPlaybackLikelyToKeepUp:
> +	       case MediaPlayerAVPlayerItemStatusPlaybackBufferFull:

...here as well.