[webkit-reviews] review canceled: [Bug 70454] [chromium] Batch up texture uploads so that they can be updated incrementally : [Attachment 111695] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has canceled Adrienne Walker
<enne at google.com>'s request for review:
Bug 70454: [chromium] Batch up texture uploads so that they can be updated
incrementally
https://bugs.webkit.org/show_bug.cgi?id=70454

Attachment 111695: Patch
https://bugs.webkit.org/attachment.cgi?id=111695&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
Work in progress patch.

If we want to interleave input and drawing during a commit, we probably need
something like this.  I figure a class than can collect all the rects will have
a better chance of estimating upload times in the GPU process, if we assume
that it's proportional to pixels uploaded.  Insert lots of hand-waving here.

Right now CCTextureUpdater just has an updateAllTextures function, but it'd be
easy enough to expose a way to partially iterate through them when needed.

One concern is that maybe this is the wrong architectural approach to upload
textures while still having the compositor thread be responsive.  James
suggested something like using multiple contexts, but I'm not totally sure I
trust the driver to handle that responsibly on all platforms.