[webkit-reviews] review granted: [Bug 70447] [GTK] Streamline wk1 documentation build : [Attachment 111686] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 70447: [GTK] Streamline wk1 documentation build
https://bugs.webkit.org/show_bug.cgi?id=70447

Attachment 111686: Patch
https://bugs.webkit.org/attachment.cgi?id=111686&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111686&action=review


This looks good to me. Would it make sense to just include the contents of
gtk-doc.make in the GNUmakefile.am?

> Source/WebKit/gtk/gtk-doc.make:5
> +####################################
> +# Everything below here is generic #
> +####################################

I think this comment is inaccurate now?

> Source/WebKit/gtk/gtk-doc.make:15
> +if GTK_DOC_USE_LIBTOOL
> +GTKDOC_CC = $(LIBTOOL) --tag=CC --mode=compile $(CC) $(INCLUDES)
$(GTKDOC_DEPS_CFLAGS) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS)
> +GTKDOC_LD = $(LIBTOOL) --tag=CC --mode=link $(CC) $(GTKDOC_DEPS_LIBS)
$(AM_CFLAGS) $(CFLAGS) $(AM_LDFLAGS) $(LDFLAGS)
> +GTKDOC_RUN = $(LIBTOOL) --mode=execute
> +else
> +GTKDOC_CC = $(CC) $(INCLUDES) $(GTKDOC_DEPS_CFLAGS) $(AM_CPPFLAGS)
$(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS)
> +GTKDOC_LD = $(CC) $(GTKDOC_DEPS_LIBS) $(AM_CFLAGS) $(CFLAGS) $(AM_LDFLAGS)
$(LDFLAGS)
> +GTKDOC_RUN =
> +endif

Can we remove this check?

> Source/WebKit/gtk/gtk-doc.make:32
> +EXTRA_DIST +=				\

This aberration from the norm tickles my obsessive side. :)

> autogen.sh:16
> -gtkdocize --copy > /dev/null 2>&1 || echo "Warning: not running gtk-docize."

> +# We do not call gtkdocize becase we use a custom version of the
> +# gtk-doc.make include

I think you can just omit this. We should let our newfound awesomeness stand
alone.