[webkit-reviews] review denied: [Bug 70077] Implement WEBGL_debug_shaders and WEBGL_debug_renderer_info extensions : [Attachment 111268] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 70077: Implement WEBGL_debug_shaders and WEBGL_debug_renderer_info
extensions
https://bugs.webkit.org/show_bug.cgi?id=70077

Attachment 111268: Patch
https://bugs.webkit.org/attachment.cgi?id=111268&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=111268&action=review


The code looks good overall. Couple of issues that need to be cleaned up.

> Source/WebCore/ChangeLog:49
> +2011-10-14  Mark Hahnenberg	<mhahnenberg at apple.com>

There's a merge problem in the ChangeLog. Please unapply, sync and reapply your
changes.

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2017
> +    }

This block is duplicated from above and needs to be removed.

> Source/WebCore/html/canvas/WebGLRenderingContext.h:630
> +    // Determine if we are running the privileged code in the browser.

"the privileged" -> "privileged". Also, for clarity, I think you should add ",
for example, a Safari or Chrome extension".

> Source/WebKit/chromium/ChangeLog:15
> +2011-10-14  Dmitry Lomov  <dslomov at google.com>

Another merge problem in the ChangeLog.