[webkit-reviews] review granted: [Bug 70396] Focus rings are too thin in HiDPI in WebKit2 : [Attachment 111671] Patch with tests

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Beth Dakin <bdakin at apple.com>'s request for review:
Bug 70396: Focus rings are too thin in HiDPI in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=70396

Attachment 111671: Patch with tests
https://bugs.webkit.org/attachment.cgi?id=111671&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=111671&action=review


> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:659
> +#if USE(CG)
> +    graphicsContext->setBaseCTM(graphicsContext->getCTM());
> +#endif

I’m having trouble deciding if this is better or worse than actually getting
the current base CTM, applying a deviceScaleFactor() scale to it, and setting
the result as the base CTM. Or perhaps a
GraphicsContext::applyDeviceScaleFactor(float) function that would do both the
scaling and (on CG) the base CTM adjustment?