[webkit-reviews] review granted: [Bug 62166] Add a suggest-nominations command to webkit-patch for computing potential committer/reviewer nominations : [Attachment 111021] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 19 14:03:08 PDT 2011


Eric Seidel <eric at webkit.org> has granted Tom Zakrajsek <tomz at codeaurora.org>'s
request for review:
Bug 62166: Add a suggest-nominations command to webkit-patch for computing
potential committer/reviewer nominations
https://bugs.webkit.org/show_bug.cgi?id=62166

Attachment 111021: Patch
https://bugs.webkit.org/attachment.cgi?id=111021&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111021&action=review


I'm willing to rubber-stamp this, so we can use it and evaluate the utility.
Seems like a huge amount of code for this.

> Tools/Scripts/webkitpy/tool/commands/suggestnominations.py:78
> +	       (message, _) = match_git_svn_id.subn("", message)
> +	       (message, _) = match_get_log_lines.subn("", message)
> +	       (message, _) = match_leading_indent.subn("", message)

Why subn and not sub?  Seems you don't want the number of subs anyway. :)


More information about the webkit-reviews mailing list