[webkit-reviews] review granted: [Bug 70418] DFG JIT 32_64 - improve double boxing/unboxing : [Attachment 111614] proposed patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Yuqiang Xian
<yuqiang.xian at intel.com>'s request for review:
Bug 70418: DFG JIT 32_64 - improve double boxing/unboxing
https://bugs.webkit.org/show_bug.cgi?id=70418

Attachment 111614: proposed patch
https://bugs.webkit.org/attachment.cgi?id=111614&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
This is excellent.  I think we might be able to do even better in some cases -
from fillSpeculateDouble, if a value is currently in memory we should probably
be loading directly into fpr rather than going via a register - we could then
compare to memory to test the tag, or compare the fpr to itself to test form
NaN-encoded values.
Still, this improvement is simple awesome!