[webkit-reviews] review denied: [Bug 70384] Support CanvasPixelArray in the DFG : [Attachment 111544] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 19 12:22:37 PDT 2011
Gavin Barraclough <barraclough at apple.com> has denied Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 70384: Support CanvasPixelArray in the DFG
https://bugs.webkit.org/show_bug.cgi?id=70384
Attachment 111544: Patch
https://bugs.webkit.org/attachment.cgi?id=111544&action=review
------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=111544&action=review
> Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:533
> + m_assembler.movb_rm(src, address.offset, address.base,
address.index, address.scale);
I believe this is unsafe on 32-bit x86.
More information about the webkit-reviews
mailing list