[webkit-reviews] review denied: [Bug 62998] Don't always select images during an image drag : [Attachment 111527] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 19 09:47:28 PDT 2011

Tony Chang <tony at chromium.org> has denied Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 62998: Don't always select images during an image drag

Attachment 111527: Patch

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111527&action=review

In general, this approach seems fine.  r- for Ryosuke's comments.

> LayoutTests/fast/events/drag-selects-image.html:16
> +	   eventSender.leapForward(500);

Nit: Making this a shorter time (like 300ms) will be nicer for QT and GTK+. I
think they implement leapForward with sleep().

> LayoutTests/fast/events/drag-selects-image.html:49
> +<p>This tests that images are properly left selected or unselected when an
image drag is started. On
> +non-Mac platforms, neither image should be selected when dragging. On Mac,
only the image in the

Is the Mac/non-Mac part still accurate?  It would also be nice to provide
instructions on how to run the test manually.

More information about the webkit-reviews mailing list