[webkit-reviews] review granted: [Bug 70350] Make FilterEffect::apply() independent of image data management : [Attachment 111597] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 19 05:53:26 PDT 2011

Zoltan Herczeg <zherczeg at webkit.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 70350: Make FilterEffect::apply() independent of image data management

Attachment 111597: Patch

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
r=me with the followings:

View in context: https://bugs.webkit.org/attachment.cgi?id=111597&action=review

> Source/WebCore/platform/graphics/filters/FEMorphology.cpp:199
>      if (hasResult())
>	   return;

Delete hasResult() here

> Source/WebCore/platform/graphics/filters/FilterEffect.cpp:92
> +bool FilterEffect::hasResult() const
> +{
> +    // This function needs platform specific checks, if the memory managment
is not done by FilterEffect.
> +    return m_imageBufferResult || m_unmultipliedImageResult ||
> +}

I think this is still need to be inline. Mush faster.

More information about the webkit-reviews mailing list