[webkit-reviews] review granted: [Bug 69814] [GTK] [WebKit2] Allow sharing page clients between WebViews : [Attachment 110474] Patch also disconnecting new signal handler on fixture destruction

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 69814: [GTK] [WebKit2] Allow sharing page clients between WebViews
https://bugs.webkit.org/show_bug.cgi?id=69814

Attachment 110474: Patch also disconnecting new signal handler on fixture
destruction
https://bugs.webkit.org/attachment.cgi?id=110474&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Seems to be basically just moving code around, so looks good to me (without
having much context about this stuff yet!). A couple of small comments:

- Seems the estimated progress property could have been moved to the view in a
previous patch. Would have made things easier to review?

- I agree with Phil that some code testing the new possibility of multiple
views per loader client makes sense.