[webkit-reviews] review granted: [Bug 70372] [nrwt] results.html should differentiate expected missing and unexpected missing : [Attachment 111522] fixes the bug

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 70372: [nrwt] results.html should differentiate expected missing and
unexpected missing
https://bugs.webkit.org/show_bug.cgi?id=70372

Attachment 111522: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=111522&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111522&action=review


> LayoutTests/fast/harness/results.html:939
> +	   forEach(document.querySelectorAll('table:not([id=missing-table])
tbody:not([mismatchreftest]) a[href$=".png"]'),
convertToTogglingHandler(function(prefix) {

table:not(#missing-table) is better. faster and more straightforward.

Can the missing table not toggle? Seems like it would be nice.

> LayoutTests/fast/harness/results.html:942
> +	   forEach(document.querySelectorAll('table:not([id=missing-table])
tbody:not([mismatchreftest]) img[src$=".png"]'),
convertToTogglingHandler(togglingImage));

ditto

> LayoutTests/fast/harness/results.html:1055
>      html += failingTestsTable(globalState().flakyTests,
>	   'Flaky tests (failed the first run and got a different result on
retry)', 'flaky-tests-table');
>  
>      if (globalState().timeoutTests.length)
>	   html += testList(globalState().timeoutTests, 'Tests that timed out',
'timeout-tests-table');
>  

Not related to this patch obviously, but noticed it looking at this code. I
wonder if we should put the flaky tests as the last list.