[webkit-reviews] review denied: [Bug 70345] Add WebKit API to hide the definition window : [Attachment 111515] patch that doesn't break SL build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 18 15:58:55 PDT 2011


Sam Weinig <sam at webkit.org> has denied	review:
Bug 70345: Add WebKit API to hide the definition window
https://bugs.webkit.org/show_bug.cgi?id=70345

Attachment 111515: patch that doesn't break SL build
https://bugs.webkit.org/attachment.cgi?id=111515&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111515&action=review


> Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h:38
> +#if !defined(BUILDING_ON_SNOW_LEOPARD)

I don't think you can do #if !defined(BUILDING_ON_SNOW_LEOPARD) in a header. 
Reversing drain's r+.  You can just put the #if
!defined(BUILDING_ON_SNOW_LEOPARD) in the implementation.


More information about the webkit-reviews mailing list