[webkit-reviews] review granted: [Bug 70358] watchlist: Should try to run if it can and not throw on mistakes. : [Attachment 111495] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 70358: watchlist: Should try to run if it can and not throw on mistakes.
https://bugs.webkit.org/show_bug.cgi?id=70358

Attachment 111495: Patch
https://bugs.webkit.org/attachment.cgi?id=111495&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111495&action=review


> Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py:145
> -	       for email in cc_rule.instructions():
> +	       for email in cc_rule.instructions()[:]:

Is this a stealth copy?  Is there a way to make this more explicit?

> Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py:147
> +		       cc_rule.remove_instruction(email)

Ah, I see.