[webkit-reviews] review granted: [Bug 70323] FrameView::layout() asserts if password field hides last character, when the document is in page cache. : [Attachment 111433] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Zalan Bujtas <zbujtas at gmail.com>'s
request for review:
Bug 70323: FrameView::layout() asserts if password field hides last character,
when the document is in page cache.
https://bugs.webkit.org/show_bug.cgi?id=70323

Attachment 111433: Patch
https://bugs.webkit.org/attachment.cgi?id=111433&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This seems like a blunt, mechanical fix that is the sort of thing we want to
avoid. We don’t want to sprinkle knowledge of the page cache around the core
browser code, if we can avoid it.

It would be much better if we could come up with a cleaner way to integrate
this.

When checking in a fix like this, we always ask for a test case. If there is no
test case possible in LayoutTests we normally suggest adding a test to the
WebCore manual-tests directory.