[webkit-reviews] review denied: [Bug 49192] Add a step to check-webkit-style to check include paths : [Attachment 111191] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 18 11:14:50 PDT 2011


Adam Barth <abarth at webkit.org> has denied James Robinson
<jamesr at chromium.org>'s request for review:
Bug 49192: Add a step to check-webkit-style to check include paths
https://bugs.webkit.org/show_bug.cgi?id=49192

Attachment 111191: Patch
https://bugs.webkit.org/attachment.cgi?id=111191&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I'd really like to have this feature, but this patch needs a bit more
iteration.  The main include_path.py should be in webkitpy.common (as a peer to
the watchlist mechanism).  Also, the config file should be in common.config (as
a peer to the watchlist mechanism).  Also, we'll want to use the filesystem
abstraction to make this more testable.

I talked a bit with jamesr about this patch, and I might take a pass at
integrating it more with webkitpy because he's got other things on his plate.


More information about the webkit-reviews mailing list