[webkit-reviews] review denied: [Bug 70304] width/height attributes of input element should be supported when the type of the input element is image. : [Attachment 111405] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Dongwoo Joshua Im
<dw.im at samsung.com>'s request for review:
Bug 70304: width/height attributes of input element should be supported when
the type of the input element is image.
https://bugs.webkit.org/show_bug.cgi?id=70304

Attachment 111405: Patch
https://bugs.webkit.org/attachment.cgi?id=111405&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Please add additional tests:

- setting value to a string that's not a valid non-negative integer (perhaps
"5.5pt");
- setting value to a string representing a negative number specifically;
- changing width and height of non-image input elements (spec says that these
attributes "do not apply" then, but what exactly does that mean?);
- how setting the value affects attributes (check node.getAttribute("width") in
addition to node.width).

Please verify that these tests have matching results in WebKit an in other
browsers implementing this.

Why this is not a [Reflect] attribute?

r- for test coverage. I don't know enough about this code to confidently
review, but I suspect that this should use [Reflect].