[webkit-reviews] review denied: [Bug 70140] Flush denormals to zero on Windows. : [Attachment 111451] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Raymond Toy <rtoy at chromium.org>'s
request for review:
Bug 70140: Flush denormals to zero on Windows.
https://bugs.webkit.org/show_bug.cgi?id=70140

Attachment 111451: Patch
https://bugs.webkit.org/attachment.cgi?id=111451&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=111451&action=review


>> Source/WebCore/platform/audio/DenormalDisabler.h:28
>> +#if OS(WINDOWS) && COMPILER(MSVC) && (_M_IX86_FP == 0)
> 
> Tests for true/false, null/non-null, and zero/non-zero should all be done
without equality comparisons.  [readability/comparison_to_zero] [5]

To satisfy the style queue the last expression should be written as
(!_M_IX86_FP). Here and below.