[webkit-reviews] review granted: [Bug 70269] Use the new cached cue loader : [Attachment 111377] Yet another patch. This time to appease my friend the style bot.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 18 08:09:06 PDT 2011


Antti Koivisto <koivisto at iki.fi> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 70269: Use the new cached cue loader
https://bugs.webkit.org/show_bug.cgi?id=70269

Attachment 111377: Yet another patch. This time to appease my friend the style
bot.
https://bugs.webkit.org/attachment.cgi?id=111377&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
The patch looks fine, the comments are really about the existing code.

Seems like lots of stuff that is currently called "Cue" should really be called
"TextTrack". CueLoader -> TextTrackLoader, CachedCues -> CachedTextTrack, etc.
Probably better to do those as a separate step. 

I'm confused by two level loader client interface. We have CueLoader which is a
CachedResourceClient. That exposed client interface of its own,
CueLoaderClient. I wonder if CueLoader and CachedCues (CachedTextTrack!)  could
merge and have just one level of clients.


More information about the webkit-reviews mailing list