[webkit-reviews] review granted: [Bug 70326] XSLStyleSheet only needs to manage XSLImportRule children. : [Attachment 111438] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 18 07:13:49 PDT 2011
Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 70326: XSLStyleSheet only needs to manage XSLImportRule children.
https://bugs.webkit.org/show_bug.cgi?id=70326
Attachment 111438: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=111438&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=111438&action=review
glorious, r=me
> Source/WebCore/xml/XSLStyleSheetLibxslt.cpp:297
> + return child->document();
> }
> + } else {
> + xmlDocPtr result =
import->styleSheet()->locateStylesheetSubResource(parentDoc, uri);
> + if (result)
> + return result;
> }
I would use continue at the end of if() and remove the else.
More information about the webkit-reviews
mailing list