[webkit-reviews] review granted: [Bug 68540] ParallelJobs: maximum number of threads should be determined dynamically : [Attachment 110511] Patch

[bugzilla-daemon at webkit.org]

Zoltan Herczeg <zherczeg at webkit.org> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 68540: ParallelJobs: maximum number of threads should be determined
dynamically
https://bugs.webkit.org/show_bug.cgi?id=68540

Attachment 110511: Patch
https://bugs.webkit.org/attachment.cgi?id=110511&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110511&action=review


r=me with the followings:

> Source/JavaScriptCore/ChangeLog:14
> +	   on the uncovered OS's which should be fixed in the future.

'the' is not needed

> Source/JavaScriptCore/wtf/ParallelJobsGeneric.cpp:51
> +    const int defaultIfUnavailable = 2;

Unused on Windows. Please put an  ifdef guard around it,

> Source/JavaScriptCore/wtf/ParallelJobsGeneric.h:59
> +	   int maxNewThreads = requestedJobNumber - 1;

rename to maxNumberOfNewThreads