[webkit-reviews] review granted: [Bug 70293] [TexMap][QT] TexMapGL renders a strange one-pixel border of BitmapTexture. : [Attachment 111371] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 17 20:28:08 PDT 2011

Noam Rosenthal <noam.rosenthal at nokia.com> has granted Hwang
<luxtella at company100.net>'s request for review:
Bug 70293: [TexMap][QT] TexMapGL renders a strange one-pixel border of

Attachment 111371: patch

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=111371&action=review

You can upload a new patch with r=me, cq? and those corrections :)

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:506
> +// Copy from GraphicsContext3D::texImage2DResourceSafe

Please put a period at the end of the sentence before committing.
I didn't realize it's the same function name as GraphicsContext3D - in that
case you can rename it back.

More information about the webkit-reviews mailing list