[webkit-reviews] review denied: [Bug 70293] [TexMap][QT] TexMapGL renders a strange one-pixel border of BitmapTexture. : [Attachment 111363] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 17 18:34:38 PDT 2011

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Hwang
<luxtella at company100.net>'s request for review:
Bug 70293: [TexMap][QT] TexMapGL renders a strange one-pixel border of

Attachment 111363: patch

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=111363&action=review

Good catch!
Some nitpicks and we're done.

> Source/WebCore/ChangeLog:9
> +	   It is because BitmapTexture is larger than original bitmap due to
POT and the
> +	   rest space of BitmapTexture would be filled undefined values.

Bug occurs because BitmapTexture is larger than the content due to rounding to
NPOT, and its pixel data is never initialized.

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:507
> +static void texImage2DResourceSafe(size_t width, size_t height)

Don't like the name... how about resetTexturePixelData?

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:511
> +    if (width > 0 && height > 0) {

those are unsigned, so 
if (width && height)

More information about the webkit-reviews mailing list