[webkit-reviews] review granted: [Bug 69990] [nrwt] Add new category for MISSING : [Attachment 111342] fixes the bug
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 17 16:22:09 PDT 2011
Dirk Pranke <dpranke at chromium.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 69990: [nrwt] Add new category for MISSING
https://bugs.webkit.org/show_bug.cgi?id=69990
Attachment 111342: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=111342&action=review
------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111342&action=review
> Tools/Scripts/webkitpy/layout_tests/port/base.py:725
> + # Don't turn bots red for flaky failures, unexpected passes, and
missing results.
Nit: Can you add a docstring to this with a more informative explanation of
what this routine is doing? (you can probably re-use the comment).
More information about the webkit-reviews
mailing list