[webkit-reviews] review requested: [Bug 70280] Scroll animator tracing : [Attachment 111339] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 17 16:03:04 PDT 2011
Scott Byer <scottbyer at chromium.org> has asked for review:
Bug 70280: Scroll animator tracing
https://bugs.webkit.org/show_bug.cgi?id=70280
Attachment 111339: Patch
https://bugs.webkit.org/attachment.cgi?id=111339&action=review
------- Additional Comments from Scott Byer <scottbyer at chromium.org>
WebKit style question here; my inclination was to create TraceEvent.h at the
platform level, renamed the one in the chromium dir to TraceEventChromium.h,
and have TraceEvent.h either include TraceEventChromium.h or empty define the
macro, so I could remove the platform conditionals from ScrollAnimatorNone.cpp.
Good impulse, or is this more minimal patch better?
More information about the webkit-reviews
mailing list