[webkit-reviews] review granted: [Bug 61287] [UNIX] Use SOCK_SEQPACKET when available : [Attachment 94982] Patch to use SEQPACKET when possible

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 61287: [UNIX] Use SOCK_SEQPACKET when available
https://bugs.webkit.org/show_bug.cgi?id=61287

Attachment 94982: Patch to use SEQPACKET when possible
https://bugs.webkit.org/attachment.cgi?id=94982&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94982&action=review

>>> Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp:196
>>> +	 }
>> 
>> I think the method call here makes the comment redundant.
> 
> Right, I added the comment because it's not obvious that a 0-byte read means
the other end closed the connection, but the method name makes it clear, so
I'll remove the comment

A comment you could leave in would be "// A zero byte read indicates that the
other end closed the connection."