[webkit-reviews] review granted: [Bug 67612] Protect against incorrect Element::fast*Attribute() usage. : [Attachment 106721] Proposed patch v3

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 67612: Protect against incorrect Element::fast*Attribute() usage.
https://bugs.webkit.org/show_bug.cgi?id=67612

Attachment 106721: Proposed patch v3
https://bugs.webkit.org/attachment.cgi?id=106721&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=106721&action=review


> Source/WebCore/css/CSSStyleSelector.cpp:926
> +    if (element->getAttribute(typeAttr) !=
m_element->getAttribute(typeAttr))

I would like more explanation of why typeAttr is animatable. Is this the same
as SVGName::typeAttr?

>> Source/WebCore/svg/SVGElement.h:105
>> +	static bool isAnimatableAttribute(const QualifiedName&);
> 
> can you call it isAnimateableSVGAttribute to make it more clear?

I think the current name is pretty clear given the context as a member of
SVGElement.