[webkit-reviews] review granted: [Bug 70134] Cues should be loaded by the cached resource loader : [Attachment 111181] Add new file to other build systems.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 70134: Cues should be loaded by the cached resource loader
https://bugs.webkit.org/show_bug.cgi?id=70134

Attachment 111181: Add new file to other build systems.
https://bugs.webkit.org/attachment.cgi?id=111181&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=111181&action=review


> Source/WebCore/loader/cache/CachedCues.cpp:53
> +    setEncodedSize(m_data.get() ? m_data->size() : 0);

Should not need a "get" here.

> Source/WebCore/loader/cache/CachedCues.cpp:56
> +    while (CachedResourceClient *client = walker.next())

The "*" needs to be next to the type here.

> Source/WebCore/loader/cache/CachedCues.h:43
> +    virtual void data(PassRefPtr<SharedBuffer> data, bool allDataReceived);

Can this be private?