[webkit-reviews] review denied: [Bug 70218] ApplicationCache - Fix Download problem with 304(Not Modified) response : [Attachment 111219] first patch for this bug

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Donggwan Kim
<donggwan.kim at samsung.com>'s request for review:
Bug 70218: ApplicationCache - Fix Download problem with 304(Not Modified)
response
https://bugs.webkit.org/show_bug.cgi?id=70218

Attachment 111219: first patch for this bug
https://bugs.webkit.org/attachment.cgi?id=111219&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Some comments: 

1. Fixes should have regression tests.

2. WebCore assumes that network layer doesn't pass 304 if it has the data. Soup
should just transform the response as if it was not cached.

3. The proposed code doesn't work correctly anyway, as the response cached by
Soup won't be saved in application cache.