[webkit-reviews] review granted: [Bug 68803] Make NavigationAction wrap a ResourceRequest instead of a KURL. : [Attachment 111109] Patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has granted  review:
Bug 68803: Make NavigationAction wrap a ResourceRequest instead of a KURL.
https://bugs.webkit.org/show_bug.cgi?id=68803

Attachment 111109: Patch
https://bugs.webkit.org/attachment.cgi?id=111109&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111109&action=review


r+, please just verify that this isn't going to compile break mac before
landing.

>>> Tools/DumpRenderTree/chromium/WebViewHost.cpp:246

>> 
>> Is this test something that should be run on all platforms?	As written this
is going to fail on everything but chromium, so we should either make it
cross-platform or make it clear thaqt it is expected to fail for everyone else
(i.e., move it to LayoutTests/platform/chromium/fast/loader/).
>> 
>> Sorry for not asking about this sooner :(
> 
> I don't think that test makes sense for other platforms, as the other ports
don't necessarily implement dispatchCreatePage the way chromium does.
> 
> The test is already in the platform/chromium/fast/loader directory

So it is.  Sorry for my apparent blindness.