[webkit-reviews] review canceled: [Bug 68803] Make NavigationAction wrap a ResourceRequest instead of a KURL. : [Attachment 111109] Patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has canceled jochen at chromium.org's request
for review:
Bug 68803: Make NavigationAction wrap a ResourceRequest instead of a KURL.
https://bugs.webkit.org/show_bug.cgi?id=68803

Attachment 111109: Patch
https://bugs.webkit.org/attachment.cgi?id=111109&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111109&action=review


> Tools/DumpRenderTree/chromium/WebViewHost.cpp:246
> -WebView* WebViewHost::createView(WebFrame*, const WebURLRequest&, const
WebWindowFeatures&, const WebString&)
> +WebView* WebViewHost::createView(WebFrame*, const WebURLRequest& request,
const WebWindowFeatures&, const WebString&)
>  {
>      if (!layoutTestController()->canOpenWindows())
>	   return 0;
> +    if (layoutTestController()->shouldDumpCreateView())
> +	   fprintf(stdout, "createView(%s)\n",
URLDescription(request.url()).c_str());
>      return m_shell->createNewWindow(WebURL())->webView();

Is this test something that should be run on all platforms?  As written this is
going to fail on everything but chromium, so we should either make it
cross-platform or make it clear thaqt it is expected to fail for everyone else
(i.e., move it to LayoutTests/platform/chromium/fast/loader/).

Sorry for not asking about this sooner :(