[webkit-reviews] review granted: [Bug 68330] Expose rangeFromLocationAndLength and locationAndLengthFromRange via internals object : [Attachment 111076] new patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 17 09:31:46 PDT 2011


Enrica Casucci <enrica at apple.com> has granted  review:
Bug 68330: Expose rangeFromLocationAndLength and locationAndLengthFromRange via
internals object
https://bugs.webkit.org/show_bug.cgi?id=68330

Attachment 111076: new patch
https://bugs.webkit.org/attachment.cgi?id=111076&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=111076&action=review


Look good to me.

> LayoutTests/editing/text-iterator/range-to-from-location-and-length.html:18
> +    testFailed('This test requires internals object');

I prefer the early return.


More information about the webkit-reviews mailing list