[webkit-reviews] review denied: [Bug 70104] [CSS Regions]Change content:-webkit-from-flow to -webkit-flow-from : [Attachment 111028] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 17 09:14:34 PDT 2011

Dave Hyatt <hyatt at apple.com> has denied Mihnea Ovidenie <mihnea at adobe.com>'s
request for review:
Bug 70104: [CSS Regions]Change content:-webkit-from-flow to -webkit-flow-from

Attachment 111028: Patch

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=111028&action=review

> Source/WebCore/css/CSSStyleSelector.cpp:3426
> +	   if (isInherit) {
> +	       m_style->setRegionThread(nullAtom);
> +	       return;

This is wrong. Any reason why you can't just use the composite macro that
handles both inherit and initial?

More information about the webkit-reviews mailing list