[webkit-reviews] review granted: [Bug 69924] Web Inspector: add "Add to Watch" option to context menu on selection in source frame : [Attachment 111262] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 17 09:06:37 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 69924: Web Inspector: add "Add to Watch" option to context menu on
selection in source frame
https://bugs.webkit.org/show_bug.cgi?id=69924

Attachment 111262: patch
https://bugs.webkit.org/attachment.cgi?id=111262&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111262&action=review


> Source/WebCore/inspector/front-end/TextViewer.js:300
> +		   this._delegate.populateTextAreaContextMenu(contextMenu);

Nit: I'd simply pass selection in.


More information about the webkit-reviews mailing list