[webkit-reviews] review granted: [Bug 70203] MediaList: Remove inheritance from StyleBase. : [Attachment 111260] Proposed patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 17 08:22:37 PDT 2011

Darin Adler <darin at apple.com> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 70203: MediaList: Remove inheritance from StyleBase.

Attachment 111260: Proposed patch v2

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=111260&action=review

> Source/WebCore/bindings/js/JSDOMBinding.h:194
> +	   CSSStyleSheet* parentStyleSheet = mediaList->parentStyleSheet();
> +	   if (parentStyleSheet)
> +	       return root(parentStyleSheet);
> +	   return 0;

I’d suggest either early return style, or defining the variable inside the if
statement conditional as the function above does.

> Source/WebCore/css/MediaList.h:80
> +    CSSStyleSheet* parentStyleSheet() const;

Since the relationship of a media list to a style sheet is not a parent/child
one, I do not think this terminology is quite right.

More information about the webkit-reviews mailing list