[webkit-reviews] review denied: [Bug 69242] Unified spell-checking and legacy spell checking should be easy to switch : [Attachment 111242] Patch

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 69242: Unified spell-checking and legacy spell checking should be easy to
switch
https://bugs.webkit.org/show_bug.cgi?id=69242

Attachment 111242: Patch
https://bugs.webkit.org/attachment.cgi?id=111242&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=111242&action=review


Generally looks fine. Could you take these small cleanup?

> Source/WebCore/editing/Editor.cpp:1682
> +    if (unifiedTextCheckerEnabled(m_frame)) {

Could you wrap this conditional as a Editor method?

> Source/WebCore/editing/Editor.cpp:2040
> +    }

Why not simply ASSERT(unifiedTextCheckerEnabled(m_frame)) ?

> Source/WebCore/editing/Editor.cpp:2239
> +    }

Ditto.

> Source/WebCore/editing/TextCheckingHelper.cpp:230
> +    if (!m_range ||
!unifiedTextCheckerEnabled(m_range->ownerDocument()->frame()))

Could you extract this criteria as a method of TextCheckingHelper?

> Source/WebCore/editing/TextCheckingHelper.cpp:509
> +    if (!m_range ||
!unifiedTextCheckerEnabled(m_range->ownerDocument()->frame()))

Ditto.

> Source/WebCore/editing/TextCheckingHelper.h:30
> +class Settings;

It looks we don't need this.