[webkit-reviews] review requested: [Bug 67720] <style scoped>: Implement selector matching : [Attachment 111229] patch (requires 67718, 67790)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 17 02:26:07 PDT 2011


Roland Steiner <rolandsteiner at chromium.org> has asked  for review:
Bug 67720: <style scoped>: Implement selector matching
https://bugs.webkit.org/show_bug.cgi?id=67720

Attachment 111229: patch (requires 67718, 67790)
https://bugs.webkit.org/attachment.cgi?id=111229&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at chromium.org>
Patch implementing scoped selector resolution. Note that a selector does NOT
store itself whether it should be scoped or not! Rather, this is an additional
parameter to the matching functions. This way selectors do not have to be
updated whenever the 'scoped' attribute on a <style> element is set or removed,
it also means that a follow-up implementation of queryScopedSelector() will be
utterly trivial.

Note that this patch is not stand-alone - it requires the patches from
https://bugs.webkit.org/show_bug.cgi?id=67718 and
https://bugs.webkit.org/show_bug.cgi?id=67790 .


More information about the webkit-reviews mailing list